Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address inconsistently localized entries in objects.inv #10882

Closed
wants to merge 3 commits into from
Closed

Address inconsistently localized entries in objects.inv #10882

wants to merge 3 commits into from

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented Sep 29, 2022

Subject: Address inconsistently localized entries in objects.inv by removing translation lazy-loader proxy class

Feature or Bugfix

  • Bugfix

Purpose

Numerous packages within Debian are identified as non-reproducible during parallel builds that are performed side-by-side using builds with English-language and Estonian-language locale configurations (among other environmental differences).

One recurring cause for these appears to be that the objects.inv file generated by Sphinx contains some (often only one, or a small number) localized display names for entries.

This behaviour appears to be inconsistent as documented in #9778.

Removing the lazy-loader _TranslationProxy class mechanism appears to help based on some local testing - although I'm yet to figure out why that is precisely.

Detail

Relates

May resolve #9778.

Attempts to address issues related to the proxy that appear to be related to the point-in-time at which resource catalogs become available during documentation builds.

Ref: #9778
@jayaddison
Copy link
Contributor Author

After more thought, I don't think that this approach is correct. The objects.inv file should be (and is) localized. Removing the translation proxy causes builds in different languages to produce the same inventory file, but I don't believe that that's what we want (because the inventory file may be published in a native language for cross-reference from other documentation sites).

@jayaddison jayaddison closed this Sep 29, 2022
@jayaddison jayaddison deleted the issue-9778/remove-lazy-translation-proxy-loader branch September 29, 2022 14:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LANGUAGE environment variable inconsistently affects output of objects.inv
1 participant