Start using pathlib.Path and deprecate sphinx.testing.path
#11526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2023
SilverRainZ
added a commit
to sphinx-notes/lilypond
that referenced
this pull request
Aug 19, 2023
bearsh
added a commit
to bearsh/git-cola
that referenced
this pull request
Aug 22, 2023
so convert it to a string, the trailing os.sep is not needed. os.path.join which is used to join paths, expects string and inserts the os.sep. See-also: sphinx-doc/sphinx#11526 See-also: sphinx-doc/sphinx#11608 Signed-off-by: Martin Gysel <me@bearsh.org>
davvid
added a commit
to davvid/sphinx-to-github
that referenced
this pull request
Aug 23, 2023
Newer versions of sphinx use a pathlib.Path object instead of a string for the "root" parameter. Add compatibility by stringifying the value provided by Sphinx. See-also: sphinx-doc/sphinx#11526 See-also: git-cola/git-cola#1336 Original-patch-by: Martin Gysel <me@bearsh.org>
davvid
added a commit
to davvid/sphinx-to-github
that referenced
this pull request
Aug 23, 2023
Newer versions of sphinx use a pathlib.Path object instead of a string for the "root" parameter. Add compatibility by stringifying the value provided by Sphinx. See-also: sphinx-doc/sphinx#11526 See-also: sphinx-doc/sphinx#11608 See-also: git-cola/git-cola#1336 Original-patch-by: Martin Gysel <me@bearsh.org>
davvid
added a commit
to davvid/sphinx-to-github
that referenced
this pull request
Aug 23, 2023
Newer versions of sphinx use a pathlib.Path object instead of a string for the "root" parameter. Add compatibility by stringifying the value provided by Sphinx. See-also: sphinx-doc/sphinx#11526 See-also: sphinx-doc/sphinx#11608 See-also: git-cola/git-cola#1336 Original-patch-by: Martin Gysel <me@bearsh.org>
davvid
pushed a commit
to davvid/git-cola
that referenced
this pull request
Aug 24, 2023
so convert it to a string, the trailing os.sep is not needed. os.path.join which is used to join paths, expects string and inserts the os.sep. See-also: sphinx-doc/sphinx#11526 See-also: sphinx-doc/sphinx#11608 Signed-off-by: Martin Gysel <me@bearsh.org> (cherry picked from commit 1293e18)
chrisjsewell
added a commit
to executablebooks/sphinx-design
that referenced
this pull request
Aug 30, 2023
Broken by sphinx-doc/sphinx#11526 😬
chrisjsewell
added a commit
to executablebooks/sphinx-design
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.