Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension broken since Sphinx 7.2.0 #137

Closed
Grokzen opened this issue Aug 18, 2023 · 0 comments · Fixed by #138
Closed

Extension broken since Sphinx 7.2.0 #137

Grokzen opened this issue Aug 18, 2023 · 0 comments · Fixed by #138

Comments

@Grokzen
Copy link
Contributor

Grokzen commented Aug 18, 2023

We noticed that Sphinx have deprecated old os.path lib and moved over to new Path lib since version 7.2.2 in the following commit
sphinx-doc/sphinx@49d8304 in the following MR sphinx-doc/sphinx#11526 that caused a breaking change that cause the latest release of this lib to break down

Due to this change that the variable app.outdir is now a PosixPath instead of a str. This cause the following line of code

filename = app.outdir + "/sitemap.xml"
to break down as it can't join PosixPath + str. The exception we get is TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str' but the stacktrace is not existing in sphinx errors.

We will fork this and submit a PR and use our fork for now until this can be released with a fix

@Grokzen Grokzen changed the title Broken since Sphinx 7.2.2 Extension broken since Sphinx 7.2.2 Aug 18, 2023
@Grokzen Grokzen changed the title Extension broken since Sphinx 7.2.2 Extension broken since Sphinx 7.2.0 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant