Rename alabaster.css_t to alabaster.css.jinja #204
Conversation
There was a problem hiding this comment.
Hi @pllim - could you update the filename to alabaster.css.jinja?
(Sphinx copies theme-related files like this one as part of a Python copy_asset method, and it will remove the suffix - either _t or .jinja - from any files considered templates that end with those. in this case, we'd like the destination file to be alabaster.css, according to the alabaster theme.conf, so either alabaster.css_t or alabaster.css.jinja should work)
|
Sure thing, I have renamed it. I apologize for misinterpreting the warning message. If you want me to squash, let me know. Otherwise, I would recommend to use the "squash and merge" button here. Thanks! |
pllim
changed the title
|
Thanks @pllim - looking further into the build warnings you saw has made me wonder whether this particular change (recommending the I mention that mainly because this change should only be applied if Sphinx 6.2.0 does decide to include support for I've written some more thoughts here: sphinx-doc/sphinx#11165 (comment) - please let me know if I can explain more. |
|
For now, we have ignored this warning in our test suite downstream, so there is no rush on my end. However, I will be interested to see how Sphinx would resolve this dilemma. Thanks for the link! |
|
Thank you @pllim (and thank you also @bsipocz for reporting the problem). I think that my preference is to rollback the change and then re-consider it for inclusion in a later release. That might be a very-cautious approach, but I'm volunteering on this so I'd also like to avoid causing too much frustration (both to myself and others). I'll spend some more time thinking about the options and waiting for any further commentary in the Sphinx project. |
|
This would break support for all released versions of Sphinx! I'll close for now, discussion continues on sphinx-doc/sphinx#11329. A |
To fix #203