Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generic badges #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support generic badges #124

wants to merge 1 commit into from

Conversation

asvetlov
Copy link

@asvetlov asvetlov commented Nov 9, 2017

Implementation for generic badges as discussed in #120

@asvetlov asvetlov mentioned this pull request Nov 9, 2017
Open
@asvetlov
Copy link
Author

@kennethreitz ping

@asvetlov asvetlov mentioned this pull request Nov 15, 2017
Closed
2 tasks
@asvetlov
Copy link
Author

@bitprophet @kennethreitz ping

@asvetlov
Copy link
Author

Ping again

@sloria sloria mentioned this pull request Sep 6, 2018
Closed
sloria
sloria approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think this one should be merged and #99 closed.

Minor thing: if the badge CSS class is added to the a tag and #143 is merged, there will be no underlines under the badges (which is desired). I can take care of that in #143 if this is merged first.

@bitprophet bitprophet added this to the 0.8 milestone Sep 12, 2018
@bitprophet bitprophet deleted the branch sphinx-doc:master January 13, 2023 00:42
@bitprophet bitprophet closed this Jan 13, 2023
@AA-Turner AA-Turner reopened this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asvetlov @sloria @bitprophet @AA-Turner