Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixup #421 #427

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: Fixup #421 #427

merged 1 commit into from
Feb 7, 2024

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Feb 7, 2024

Quick fixup that I caught in #397. If CMAKE_Fortran_COMPILER is defined, but the language is not enabled, the previous version failed at try_compile

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT added the bug label Feb 7, 2024
@LecrisUT LecrisUT enabled auto-merge (squash) February 7, 2024 18:40
@LecrisUT LecrisUT added this to the 2.3 milestone Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62843bc) 83.71% compared to head (4238b1d) 83.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    83.71%   83.71%           
========================================
  Files           24       24           
  Lines         8205     8205           
========================================
  Hits          6869     6869           
  Misses        1336     1336           
Flag Coverage Δ
c_api 77.50% <ø> (ø)
fortran_api 56.33% <ø> (ø)
python_api 79.94% <ø> (ø)
unit_tests 1.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT mentioned this pull request Feb 7, 2024
@LecrisUT LecrisUT merged commit 5b18822 into spglib:develop Feb 7, 2024
36 of 40 checks passed
@LecrisUT LecrisUT deleted the fix/fixup-421 branch February 8, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant