fix: Fortran api #421
Merged
fix: Fortran api #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
|
This new spglib_f08.F90 works ok in my setup. Thanks! |
LecrisUT
added a commit
to LecrisUT/spglib
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #421 +/- ##
========================================
Coverage 83.71% 83.71%
========================================
Files 24 24
Lines 8205 8205
========================================
Hits 6869 6869
Misses 1336 1336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
fix/Fortran-api
branch
from
55f60b9
to
057cbbc
Compare
|
/packit build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spglib_f08.F90not having thespglib_versionFortran moduleSpglib::fortran_includeandSpglib::fortran_modso thatSpglib::fortranis an alias is to either of these depending on if the.modfile is importable or notTODO:
This PR should be added for a Spglib v2.3.1
Closes #415, #416
@dmt4 thanks for opening those issues, I am quite glad how this design turned out, and I will present this at an upcoming meeting. Do you want to take it for a spin?