Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reorganize Fortran interface #396

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

LecrisUT
Copy link
Collaborator

A quick PR to re-organize the fortran api to be more legible and extendable. I am also considering splitting it into a header-source file, but at the moment there is little gain since CMake does not support bundling these files like with cxx-modules.

@lan496 lan496 removed their request for review January 19, 2024 23:47
@lan496
Copy link
Member

lan496 commented Jan 19, 2024

I would defer the Fortran interface on @atztogo .

Copy link
Collaborator

@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me good. Thanks @LecrisUT.

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c168e89) 83.86% compared to head (bb3eb2d) 83.85%.

Files Patch % Lines
fortran/spglib_f08.F90 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #396      +/-   ##
===========================================
- Coverage    83.86%   83.85%   -0.02%     
===========================================
  Files           24       24              
  Lines         8180     8181       +1     
===========================================
  Hits          6860     6860              
- Misses        1320     1321       +1     
Flag Coverage Δ
c_api 77.59% <ø> (ø)
fortran_api 56.14% <57.14%> (-0.01%) ⬇️
python_api 80.38% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT enabled auto-merge (squash) January 20, 2024 11:28
@LecrisUT LecrisUT merged commit c945bae into spglib:develop Jan 20, 2024
42 of 57 checks passed
@LecrisUT LecrisUT deleted the feat/fortran-organize branch January 20, 2024 13:11
@LecrisUT LecrisUT added this to the 2.3 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants