Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add Go 1.20 to build matrix #1506

Merged
merged 3 commits into from
Apr 6, 2023
Merged

ci: add Go 1.20 to build matrix #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1489321
ci: add Go 1.20 to build matrix
sagikazarmark Feb 5, 2023
d2cec09
chore: update linter
sagikazarmark Apr 6, 2023
13fafb8
test: fix test to actually assert something
sagikazarmark Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.19
go-version: '1.20'

- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -43,7 +43,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
go: ['1.17', '1.18', '1.19']
go: ['1.17', '1.18', '1.19', '1.20']
env:
GOFLAGS: -mod=readonly

Expand Down Expand Up @@ -74,12 +74,12 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.19
go-version: '1.20'

- name: Checkout code
uses: actions/checkout@v3

- name: Lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.50.1
version: v1.52.2
8 changes: 5 additions & 3 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ linters:
disable-all: true
enable:
- bodyclose
- deadcode
- dogsled
- dupl
- durationcheck
Expand All @@ -43,14 +42,12 @@ linters:
- rowserrcheck
- sqlclosecheck
- staticcheck
- structcheck
- stylecheck
- tparallel
- typecheck
- unconvert
- unparam
- unused
- varcheck
- wastedassign
- whitespace

Expand Down Expand Up @@ -83,6 +80,11 @@ linters:
# - goheader
# - gomodguard

# deprecated
# - deadcode
# - structcheck
# - varcheck

# don't enable:
# - asciicheck
# - funlen
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ TEST_FORMAT = short-verbose
endif

# Dependency versions
GOTESTSUM_VERSION = 1.8.0
GOLANGCI_VERSION = 1.50.1
GOTESTSUM_VERSION = 1.9.0
GOLANGCI_VERSION = 1.52.2

# Add the ability to override some variables
# Use with care
Expand Down
4 changes: 3 additions & 1 deletion viper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"bytes"
"encoding/json"
"io"
"io/ioutil" //nolint:staticcheck
"io/ioutil"
"os"
"os/exec"
"path"
Expand Down Expand Up @@ -874,8 +874,10 @@ func TestAliasesOfAliases(t *testing.T) {
}

func TestRecursiveAliases(t *testing.T) {
Set("baz", "bat")
RegisterAlias("Baz", "Roo")
RegisterAlias("Roo", "baz")
assert.Equal(t, "bat", Get("Baz"))
}

func TestUnmarshal(t *testing.T) {
Expand Down