Add env variable to suppress completion descriptions on create

[scop]

Closes #1937

[marckhouzam]

Thanks @scop !
This approach will only work for programs that use the default completion command. Also it would require regenerating the completion script to toggle the descriptions.

Instead we could have the go code itself check the new variable and not return descriptions with the list of completions.

This is what we do for activehelp and probably what I should have done for descriptions from the start.

This go logic would be here:

cobra/completions.go

Line 200 in 4dd4b25

noDescriptions := (cmd.CalledAs() == ShellCompNoDescRequestCmd)

[Luap99]

I agree we should follow what active helps does , this includes support for two env vars, i.e. COBRA_COMPLETION_NO_DESCRIPTIONS and <PROGRAM>_COMPLETION_NO_DESCRIPTIONS, this allows users to still configure it on a per application basis without having to regenerate the completion script.

[marckhouzam]

Thanks for the input @Luap99 👍

COBRA_COMPLETION_NO_DESCRIPTIONS and _COMPLETION_NO_DESCRIPTIONS

Let's "go" 😆 with this flexible and"standard" approach if @scop is willing.

[scop]

Makes sense. I suggest we take a look at #1940 before reworking this though -- if/after that's in, the env var prefix handling could be generalized and shared between active help and this feature.

[scop]

I suppose this is starting to take shape, however it requires #1940, so keeping as a draft until that's in.

This will also cause conflicts with #1957, so either this or that will eventually need rebasing. This one's still blocked and #1957 is not, so perhaps that one could be applied first? Then again, I would not want to delay this one any more.

[github-actions]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[scop]

Resolved conflicts, rebased.

[marckhouzam]

Thanks for your patience @scop

[github-actions]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[scop]

Thanks for the review, @marckhouzam, feedback addressed.

[marckhouzam]

Very nice!
Thanks @scop.