Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle timezone-aware datetime objects when writing SPDX. #768

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Handle timezone-aware datetime objects when writing SPDX. #768

merged 2 commits into from
Oct 12, 2023
+33 −3

Conversation

licquia
Copy link
Collaborator

@licquia licquia commented Oct 5, 2023

Fixes #766.

Handle timezone-aware datetime objects when writing SPDX.
c74ec55 
Fixes spdx#766.

Signed-off-by: Jeff Licquia <jeff@licquia.org>
@licquia
Copy link
Collaborator Author

licquia commented Oct 5, 2023

Looks like I didn't add the test dependency tzdata correctly, or missed something. I'll look in the morning, or if someone wants to just ensure tzdata is installed as a test dependency everywhere it's needed, that should clear out the test failure.

Properly install tzdata for GitHub Actions.
c95b0bb 
Signed-off-by: Jeff Licquia <jeff@licquia.org>
maxhbr
maxhbr reviewed Oct 5, 2023
View reviewed changes
armintaenzertng
armintaenzertng approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armintaenzertng armintaenzertng merged commit f0873eb into spdx:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr

@armintaenzertng armintaenzertng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spdx_tools created field does not matches the specification
3 participants
@licquia @maxhbr @armintaenzertng