Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoding parameter for parsing files #756

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

chrisdecker1201
Copy link
Contributor

maxhbr
maxhbr previously approved these changes Sep 7, 2023
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks for that contribution.

@chrisdecker1201 chrisdecker1201 changed the title add encoding parameter for parseing files add encoding parameter for parsing files Sep 8, 2023
@chrisdecker1201 chrisdecker1201 force-pushed the feature/parse_file_encoding branch from 5a541b1 to 8fb5d04 Compare September 8, 2023 09:54

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Christian Decker <christian.decker@homag.com>
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armintaenzertng armintaenzertng merged commit 44196ef into spdx:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants