Skip to content

Pytest + py2.7 support removal + CI fixes #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 15, 2021
Merged

Pytest + py2.7 support removal + CI fixes #179

merged 13 commits into from
Jul 15, 2021
+314 −725

Conversation

tardyp
Copy link
Contributor

@tardyp tardyp commented Jul 2, 2021 •
edited
Loading

Fix: #177
Fix: #176

There is a lot of search replace here, I separated each in separate commit for easier review.

tardyp added 13 commits July 2, 2021 16:21
@tardyp
fix setup.py
170fa62 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
simplify isinstance(six.string_types, six.text_type) -> isinstance(str)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c151d38 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
six.string_types -> str
68aed88 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
from six.moves import reduce -> functools

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8f8ced1 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
ziplongest is in itertools
08ff7fc 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
string_types -> str

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3221a99 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
six.text_type -> str
c3de47a 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
remove six imports

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7a9fb9f 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
remove from __future__
a76ded1 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
remove some if PY2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
607a9c3 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
setup CI with pytest and implement a bit of DRY in circle-ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9824949 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
fix CI to use docker
2a88975 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
some more if PY[23] removal
565882a 
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp tardyp mentioned this pull request Jul 8, 2021
Closed
pombredanne
pombredanne approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a lot of tedious work and done in a pristine and clean way!
Merging now.

@pombredanne pombredanne merged commit 5ea21ab into spdx:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use pytest drop python < 3.6 support
2 participants
@tardyp @pombredanne