Factorise parsing and conversion #174
Merged
+814
−1,364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tardyp
force-pushed
the
factorise_parsing
branch
from
8ecd38b to
f657272
Compare
|
I did not realize this is not using pytest. I would suggest to use it as it is defacto standard, and has a lot of nice functionality to improve testability |
a lot of the examples are actually the same code and the cli is using it We factorize it so that it is easier to make some more converters Signed-off-by: Pierre Tardy <tardyp@gmail.com>
instead of having the same boilerplate in all the convertors, we just factorize in a single function that can output any format according to the file extension The tests show that the conversion is not fully stable. fixing that is out of scope of this commit, and requires more investigation Signed-off-by: Pierre Tardy <tardyp@gmail.com>
tardyp
force-pushed
the
factorise_parsing
branch
from
f657272 to
56d1616
Compare
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
tardyp
force-pushed
the
factorise_parsing
branch
from
22d8865 to
8f72d84
Compare
…ll names Signed-off-by: Pierre Tardy <tardyp@gmail.com>
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
Fix some test by regenerating the expected data Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
tardyp
force-pushed
the
factorise_parsing
branch
from
8f72d84 to
49cab4b
Compare
Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
tardyp
force-pushed
the
factorise_parsing
branch
from
abafce0 to
e27cc07
Compare
previous version of the test was unstable to directory order the first file found was used, and some more simple files have good conversion while more complex are failing Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
tardyp
force-pushed
the
factorise_parsing
branch
from
e27cc07 to
3eda4f9
Compare
Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
tardyp
force-pushed
the
factorise_parsing
branch
from
e8d774f to
3efab86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example dir looks very confusing with lots of similar code, and the CLI is actually using it.
This PR provide factorization, so that it is easier to write a custom converter without having to copy paste too much boileplate.
The tests show that the conversion is not fully stable.
fixing that is out of scope of this PR, and requires more investigation