Fix write_tv example #133
Merged
Fix write_tv example #133
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing example for write_tv requires a couple of fields in the Document, Package and File objects that are not defined. This causes the example to fail, which makes its goal of being a reference for current implementors
The current version of the example fails with "Document is Invalid" errors, which makes it rather hard to understand what is invalid about the document. Further, the exception caught itself presents is already floating information about which checks specifically made the document invalid. Present this information to the user in such a way that they can identify and fix the errors in their document
|
It would be nice to have this merged as the example does not work. |
|
Merged at last! thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been fiddling with the python library lately. I found a couple of little
hiccups in the write_tv example. I'm opening this PR so I don't forget,
although I'll admit I haven't done my due dilligence figuring out if this
example is in fact already fixed somewhere else (and apologies for that!).
Also, the spdx_id fields that I chose may prove to be not entirely compliant,
as I just read the validation code and picked something that passed...