Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define parameters as a structure #222

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Define parameters as a structure #222

merged 3 commits into from
Nov 30, 2023

Conversation

spaze
Copy link
Owner

@spaze spaze commented Nov 29, 2023

Close #192

Follow-up bug fixes #229 #231

@spaze spaze self-assigned this Nov 29, 2023
@spaze spaze merged commit f940bc8 into main Nov 30, 2023
74 checks passed
@spaze spaze deleted the spaze/parameters-structure branch November 30, 2023 01:27
spaze pushed a commit to francescolaffi/phpstan-disallowed-calls that referenced this pull request Dec 12, 2023
spaze added a commit that referenced this pull request Dec 12, 2023
…nal (#229)

Gave a test run of some disallowed attributes on properties after #225, noticed errorIdentifier and errorTip are considered mandatory but I'm guessing it was not intended in #222.
spaze added a commit that referenced this pull request Dec 13, 2023
spaze added a commit that referenced this pull request Dec 13, 2023
@spaze
Copy link
Owner Author

spaze commented Dec 22, 2023

Released in 3.0.0.

spaze added a commit that referenced this pull request Feb 13, 2024
PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore.
phpstan/phpstan-src#2907

The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests.

Close #249

Introduced in #222 as a fix for phpstan/phpstan#10223
spaze added a commit that referenced this pull request Feb 13, 2024
…fig (#250)

PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore.
phpstan/phpstan-src#2907

The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests.

Close #249

Introduced in #222 as a fix for phpstan/phpstan#10223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension parameters in extension.neon should be defined as a structure
1 participant