Test one attribute with an attribute with multiple different values (#…

…240) Ref #238
spaze · Jan 11, 2024 · 3d18e0f · 3d18e0f
2 parents 90fdf80 + 44ffd4d
commit 3d18e0f
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 5 deletions.
diff --git a/tests/Usages/AttributeUsagesAllowParamsInAllowedTest.php b/tests/Usages/AttributeUsagesAllowParamsInAllowedTest.php
@@ -70,15 +70,15 @@ public function testRule(): void
 			],
 			[
 				'Attribute Attributes\AttributeEntity is forbidden.',
-				22,
+				25,
 			],
 			[
 				'Attribute Attributes\AttributeEntity is forbidden.',
-				28,
+				31,
 			],
 			[
 				'Attribute Attributes\AttributeEntity is forbidden.',
-				42,
+				45,
 			],
 		]);
 	}

diff --git a/tests/Usages/AttributeUsagesTest.php b/tests/Usages/AttributeUsagesTest.php
@@ -3,6 +3,7 @@
 
 namespace Spaze\PHPStan\Rules\Disallowed\Usages;
 
+use Attributes\AttributeColumn;
 use Attributes\AttributeEntity;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
@@ -33,6 +34,22 @@ protected function getRule(): Rule
 				[
 					'attribute' => '#[\Attributes\AttributeClass()]',
 				],
+				[
+					'attribute' => AttributeColumn::class,
+					'message' => 'use `utc_datetime_immutable` instead.',
+					'allowExceptCaseInsensitiveParams' => [
+						[
+							'name' => 'type',
+							'position' => 2,
+							'value' => 'datetime',
+						],
+						[
+							'name' => 'type',
+							'position' => 2,
+							'value' => 'datetime_immutable',
+						],
+					],
+				],
 			]
 		);
 	}
@@ -60,13 +77,17 @@ public function testRule(): void
 				'Attribute Attributes\AttributeEntity is forbidden.',
 				18,
 			],
+			[
+				'Attribute Attributes\AttributeColumn is forbidden, use `utc_datetime_immutable` instead.',
+				21,
+			],
 			[
 				'Attribute Attributes\AttributeClass is forbidden.',
-				40,
+				43,
 			],
 			[
 				'Attribute Attributes\AttributeEntity is forbidden.',
-				42,
+				45,
 			],
 		]);
 

diff --git a/tests/src/AttributeColumn.php b/tests/src/AttributeColumn.php
@@ -0,0 +1,16 @@
+<?php
+declare(strict_types = 1);
+
+namespace Attributes;
+
+#[Attribute]
+class AttributeColumn
+{
+
+	public function __construct(
+		?string $name = null,
+		?string $type = null
+	) {
+	}
+
+}
diff --git a/tests/src/ClassWithAttributes.php b/tests/src/ClassWithAttributes.php
@@ -18,6 +18,9 @@ class ClassWithAttributes
 	#[AttributeEntity]
 	public static $pepper = 'ofc';
 
+	#[AttributeColumn(name: 'start_date_parsed', type: 'datetime')]
+	private $fries = 'large';
+
 
 	#[AttributeEntity(repositoryClass: UserRepository::class, readOnly: false)]
 	public function hasAvocado(): bool