Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Context middleware #185

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

stayallive
Copy link
Contributor

Saw you also support the new Laravel Context feature now.

Noticed that a variable was not re-used and that no tests were added for this feature.

Hope you don't mind me submitting a PR for that 馃憤

@stayallive
Copy link
Contributor Author

It looks like the beforeEach runs before the skip is resolved... interesting. But anyway, should have fixed my mistake there.

It also looks like there are a massive amount of other tests failing because of missing .env and such, can't think of how any of my changes triggered that? But maybe I'm overlooking something.

@freekmurze freekmurze merged commit ed76239 into spatie:main Apr 1, 2024
29 of 33 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants