Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay breaking out of the parse loop when max_tree_depth is hit #3100

Merged
merged 2 commits into from Jan 17, 2024
Merged

Delay breaking out of the parse loop when max_tree_depth is hit #3100

merged 2 commits into from Jan 17, 2024

Commits on Jan 16, 2024

  1. Delay breaking out of the parse loop when max_tree_depth is hit 

    When a token causes a node to be added to the DOM which increases the
depth of the DOM to exceed the `max_tree_depth` _and_ the token needs to
be reprocessed, memory is leaked. By delaying breaking out of the loop
until after the token has been completely handled, this appears to fix
the leak.

Fixes sparklemotion#3098
    @stevecheckoway
    stevecheckoway committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    de6bcd2 View commit details
    Browse the repository at this point in the history

  2. Add test

    @stevecheckoway
    stevecheckoway committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2e26a72 View commit details
    Browse the repository at this point in the history