Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport updates and fixes to v1.15.x #2953

Merged
merged 7 commits into from
Aug 11, 2023
Merged

backport updates and fixes to v1.15.x #2953

merged 7 commits into from
Aug 11, 2023

Commits on Aug 11, 2023

  1. ci: update suppression stack signature 

    something changed recently, not sure if it's the compiler in CI, or
the library, or a combination.

(cherry picked from commit 871cd51)
    @flavorjones
    flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    d1c62de View commit details
    Browse the repository at this point in the history

  2. style: prefer Minitest to MiniTest 

    since Minitest 5.19 doesn't load it by default

(cherry picked from commit a29042b)
    @flavorjones
    flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    8d8c728 View commit details
    Browse the repository at this point in the history

  3. ci: ruby-saml's downstream test suite needs minitest compat 

    (cherry picked from commit 87d3c11)
    @flavorjones
    flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    a6fc29b View commit details
    Browse the repository at this point in the history

  4. Fix typo 

    (cherry picked from commit 5b65501)
    @anishathalye @flavorjones
    anishathalye authored and flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    1617d54 View commit details
    Browse the repository at this point in the history

  5. fix memsize_node when called on xmlAttrs 

    The `properties` field of an `xmlNode` element points to an `xmlAttr`.
The first few fields of `xmlAttr` are in common with `xmlNode`, but not
the `properties` field which doesn't exist in an `xmlAttr`.

The `memsize_node` function was passing an `xmlAttr` to a
recursive call and then trying to do the same with the properties of
that.

This led to type confusion and subsequent crashes.

Fixes: #2923
(cherry picked from commit 81762fa)
    @stevecheckoway @flavorjones
    stevecheckoway authored and flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    c39ec30 View commit details
    Browse the repository at this point in the history

  6. test: add coverage for the memsize_of bug 

    which turns out to be because xmlDTD has "attributes" where xmlNode
has "properties"

(cherry picked from commit 19a64ba)
    @flavorjones
    flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    14d1f5a View commit details
    Browse the repository at this point in the history

  7. dep: update libxml2 to v2.11.5 

    https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.11.5
(cherry picked from commit f7940b7)
    @flavorjones
    flavorjones committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    8460bfe View commit details
    Browse the repository at this point in the history