Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly serialize UTF-16 documents that are longer than libxml2's internal string buffer #2434

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Correctly serialize UTF-16 documents that are longer than libxml2's internal string buffer #2434

merged 3 commits into from
Jan 23, 2022
+96 −59

Commits on Jan 23, 2022

  1. style: clean up noko_io_* functions ahead of bugfix

    @flavorjones
    flavorjones committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    ea27f02 View commit details
    Browse the repository at this point in the history

  2. style: convert doc encoding tests to minispec 

    and consolidate and rewrite a few tests
    @flavorjones
    flavorjones committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    0af1c5b View commit details
    Browse the repository at this point in the history

  3. fix: long UTF-16 documents serialize correctly 

    UTF-16 documents that are long enough to trigger an intermediate
libxml2 buffer flush are now serialized correctly.

This change works by setting the external encoding on the StringIO
object, and then using that encoding when constructing intermediate
strings from libxml2's buffer.
    @flavorjones
    flavorjones committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    2e260f5 View commit details
    Browse the repository at this point in the history