backport updates and fixes to v1.15.x #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
something changed recently, not sure if it's the compiler in CI, or the library, or a combination. (cherry picked from commit 871cd51)
flavorjones
force-pushed
the
flavorjones-backport-v1.15.x-20230811
branch
from
f2ee926
to
ad59d0e
Compare
1 task
since Minitest 5.19 doesn't load it by default (cherry picked from commit a29042b)
(cherry picked from commit 87d3c11)
The `properties` field of an `xmlNode` element points to an `xmlAttr`. The first few fields of `xmlAttr` are in common with `xmlNode`, but not the `properties` field which doesn't exist in an `xmlAttr`. The `memsize_node` function was passing an `xmlAttr` to a recursive call and then trying to do the same with the properties of that. This led to type confusion and subsequent crashes. Fixes: #2923 (cherry picked from commit 81762fa)
which turns out to be because xmlDTD has "attributes" where xmlNode has "properties" (cherry picked from commit 19a64ba)
https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.11.5 (cherry picked from commit f7940b7)
flavorjones
force-pushed
the
flavorjones-backport-v1.15.x-20230811
branch
from
ad59d0e
to
8460bfe
Compare
flavorjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Backporting changes from: