Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Add PR auto labeler #558

Merged
merged 2 commits into from Apr 23, 2021
Merged

MNT: Add PR auto labeler #558

merged 2 commits into from Apr 23, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 22, 2021

This would automatically label new PRs according to the given rules using actions/labeler. With this in place, here is the new triage workflow for humans:

  1. Wait for labeler to get done.
  2. Manually add any relevant labels that are not covered by the rules, if applicable.

If you manually add labels too early, you might encounter this bug: actions/labeler#112

You can see it in action (pun?) over at astropy:

Screenshot 2021-04-22 152208

@pllim pllim added the 💤 enhancement New feature or request label Apr 22, 2021
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful, thanks!

Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the way to test this is to actually merge it and then see its effects when we submit new PRs? Anyways, it looks correct from a cursory examination as per github instructions on how to do this.

@pllim
Copy link
Contributor Author

pllim commented Apr 23, 2021

the way to test this

One could also unleash this on a fork and try it out over there, but probably much easier to merge and "test it live".

@rosteen
Copy link
Collaborator

rosteen commented Apr 23, 2021

I'm fine with "live testing" this and making changes later if needed.

@rosteen rosteen merged commit a48cf08 into spacetelescope:main Apr 23, 2021
@pllim pllim deleted the pr-labeler branch April 23, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants