Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-121] rename master -> main #135

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jan 30, 2024

resolves SCSB-121

preparation for branch rename

@zacharyburnett zacharyburnett self-assigned this Jan 30, 2024
@zacharyburnett zacharyburnett changed the title rename references to master -> main rename master -> main Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3f73e1) 75.29% compared to head (19974f3) 75.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files           7        7           
  Lines         344      344           
=======================================
  Hits          259      259           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review January 30, 2024 15:16
@zacharyburnett zacharyburnett requested a review from a team as a code owner January 30, 2024 15:16
@zacharyburnett zacharyburnett changed the title rename master -> main [SCSB-116] rename master -> main Jan 30, 2024
@zacharyburnett zacharyburnett changed the title [SCSB-116] rename master -> main [SCSB-121] rename master -> main Jan 30, 2024
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Jan 30, 2024

Windows builds are failing for some reason; I do not think that is related to this PR

@mcara
Copy link
Member

mcara commented Jan 30, 2024

Windows builds are failing for some reason; I do not think that is related to this PR

Run pypa/cibuildwheel@v2.16.4
Run actions/setup-python@v5
Installed versions
Run pipx run --python "C:\hostedtoolcache\windows\Python\3.12.1\x64\python.exe" --spec "D:\a\_actions\pypa\cibuildwheel\v2.16.4" cibuildwheel "." --output-dir '"dist"' --config-file '""' --only '""'
  pipx run --python "C:\hostedtoolcache\windows\Python\3.12.1\x64\python.exe" --spec "D:\a\_actions\pypa\cibuildwheel\v2.16.4" cibuildwheel "." --output-dir '"dist"' --config-file '""' --only '""'
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    CIBW_TEST_COMMAND: 
    CIBW_BUILD: cp3*-win_amd64
    CIBW_ARCHS: auto
creating virtual environment...
determining package name from 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.16.4'...
creating virtual environment...
installing cibuildwheel from spec 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.16.4'...
Invalid --only='""', must be a build selector with a known platform
Error: Process completed with exit code 1.

Invalid --only='""', must be a build selector with a known platform I don't know anything about this. Why suddenly this stopped working?

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Jan 31, 2024

It appears that this is due to an update in the build action pypa/cibuildwheel that caused this error in the Windows environment; pypa/cibuildwheel released a hotfix just yesterday that claims to fix this error, but that has not yet been propagated to the OpenAstronomy workflow (they're still using the broken version).

I made a PR here to fix that OpenAstronomy/github-actions-workflows#184; after that is merged and tagged, we can rerun this workflow here and it should be fixed.

@zacharyburnett
Copy link
Collaborator Author

In the meantime, however, as this issue is not related to this PR, I think this can be merged

@mcara mcara merged commit d2fc65a into spacetelescope:master Feb 3, 2024
21 checks passed
@zacharyburnett zacharyburnett deleted the rename/master branch February 5, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants