Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - increase cache size to 50 000 for next release #5079

Closed
wants to merge 2 commits into from

Conversation

dshulyak
Copy link
Contributor

there are many places that have to read atxs, if number of atxs in epoch larger then what we cache it causes cache threshing
signficant and disk reads. for example in this epoch nodes in cloud peek every 5m with 140MB/s reads.

i set it to 50 000 to account for possible growth in the next epoch.

@dshulyak dshulyak changed the title increase cache size to 50_000 for next release increase cache size to 50 000 for next release Sep 25, 2023
@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 25, 2023
there are many places that have to read atxs, if number of atxs in epoch larger then what we cache it causes cache threshing
signficant and disk reads. for example in this epoch nodes in cloud peek every 5m with 140MB/s reads.

i set it to 50 000 to account for possible growth in the next epoch.
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #5079 (2ae04ed) into develop (23f65a2) will decrease coverage by 0.1%.
Report is 1 commits behind head on develop.
The diff coverage is 100.0%.

❗ Current head 2ae04ed differs from pull request most recent head 1c262ef. Consider uploading reports for the commit 1c262ef to get more accurate results

@@            Coverage Diff            @@
##           develop   #5079     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          257     257             
  Lines        30277   30277             
=========================================
- Hits         23349   23346      -3     
- Misses        5402    5404      +2     
- Partials      1526    1527      +1     
Files Changed Coverage Δ
datastore/store.go 71.3% <100.0%> (ø)

... and 3 files with indirect coverage changes

@bors
Copy link

bors bot commented Sep 25, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 25, 2023
there are many places that have to read atxs, if number of atxs in epoch larger then what we cache it causes cache threshing
signficant and disk reads. for example in this epoch nodes in cloud peek every 5m with 140MB/s reads.

i set it to 50 000 to account for possible growth in the next epoch.
@bors
Copy link

bors bot commented Sep 25, 2023

Build failed:

@countvonzero
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Sep 25, 2023
there are many places that have to read atxs, if number of atxs in epoch larger then what we cache it causes cache threshing
signficant and disk reads. for example in this epoch nodes in cloud peek every 5m with 140MB/s reads.

i set it to 50 000 to account for possible growth in the next epoch.
@bors
Copy link

bors bot commented Sep 25, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title increase cache size to 50 000 for next release [Merged by Bors] - increase cache size to 50 000 for next release Sep 25, 2023
@bors bors bot closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants