[Merged by Bors] - sync: parametrize out of sync threshold and set it to 3h for mainnet #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
requested review from
countvonzero,
fasmat and
poszu
as code owners
dshulyak
force-pushed
the
parametrize-out-of-sync-threshold
branch
from
425aeb9
to
5bdb8b1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5040 +/- ##
=========================================
- Coverage 77.1% 77.1% -0.1%
=========================================
Files 257 257
Lines 30275 30277 +2
=========================================
Hits 23348 23348
- Misses 5401 5402 +1
- Partials 1526 1527 +1
|
fasmat
approved these changes
Sep 20, 2023
|
bors merge |
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #5036
in future we should drop it completely, and use only connectivity information to decide if node should stop participating
in consensus. there should be no risk of interrupting consensus, because of any unexpected failures in sync process.