Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - add index for faster query to get refballot #5038

Closed

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Sep 19, 2023

there was a regression in proposal builder that started to use codepath that was used in different domain, which was executed once per epoch. now this is executed on every proposal creation and might be too slow.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #5038 (c744556) into develop (f629581) will increase coverage by 0.0%.
The diff coverage is 83.3%.

@@           Coverage Diff           @@
##           develop   #5038   +/-   ##
=======================================
  Coverage     77.1%   77.1%           
=======================================
  Files          257     257           
  Lines        30254   30254           
=======================================
+ Hits         23330   23332    +2     
+ Misses        5398    5397    -1     
+ Partials      1526    1525    -1     
Files Changed Coverage Δ
sql/database.go 70.7% <80.0%> (ø)
node/node.go 63.4% <100.0%> (ø)

... and 4 files with indirect coverage changes

@dshulyak dshulyak changed the title add index for faster query to refballot add index for faster query to get refballot Sep 19, 2023
@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 20, 2023
there was a regression in proposal builder that started to use codepath that was used in different domain, which was executed once per epoch. now this is executed on every proposal creation and might be too slow.
@bors
Copy link

bors bot commented Sep 20, 2023

Build failed:

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 20, 2023
there was a regression in proposal builder that started to use codepath that was used in different domain, which was executed once per epoch. now this is executed on every proposal creation and might be too slow.
@bors
Copy link

bors bot commented Sep 20, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title add index for faster query to get refballot [Merged by Bors] - add index for faster query to get refballot Sep 20, 2023
@bors bors bot closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants