[Merged by Bors] - remove read/write for ballot.ActiveSet #5024
Conversation
countvonzero
requested review from
dshulyak,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5024 +/- ##
=========================================
- Coverage 77.2% 77.1% -0.1%
=========================================
Files 254 254
Lines 30102 30113 +11
=========================================
- Hits 23247 23242 -5
- Misses 5351 5362 +11
- Partials 1504 1509 +5
|
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
proposals/eligibility_validator.go
Outdated
| @@ -140,11 +141,15 @@ func (v *Validator) validateReference(ballot *types.Ballot, owned *types.Activat | |||
| if ballot.EpochData.Beacon == types.EmptyBeacon { | |||
| return nil, fmt.Errorf("%w: ref ballot %v", errMissingBeacon, ballot.ID()) | |||
| } | |||
| if len(ballot.ActiveSet) == 0 { | |||
| activeSet, err := activesets.Get(v.cdb, ballot.EpochData.ActiveSetHash) | |||
There was a problem hiding this comment.
there should be a way to avoid this read. we should have loaded this data earlier, as we need to check data availability. and then we need to pass it together with the rest of the ballot for eligibility validation
There was a problem hiding this comment.
thanks. changed to pass it from the original lookup.
|
bors merge |
## Motivation Closes #4984 ## Changes - drop EmitEmptyActiveSet config - remove all access to Ballot.ActiveSet and look up from db instead - remove all writes of Ballot.ActiveSet after this PR, miner will still accept proposal/ballot with non-empty active sets, but will save ballots without active set.
|
bors cancel |
|
Canceled. |
|
bors merge |
## Motivation Closes #4984 ## Changes - drop EmitEmptyActiveSet config - remove all access to Ballot.ActiveSet and look up from db instead - remove all writes of Ballot.ActiveSet after this PR, miner will still accept proposal/ballot with non-empty active sets, but will save ballots without active set.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Motivation
Closes #4984
Changes
after this PR, miner will still accept proposal/ballot with non-empty active sets, but will save ballots without active set.