Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - drop support for old sync and other legacy code #5021

Closed
wants to merge 7 commits into from

Conversation

countvonzero
Copy link
Contributor

Motivation

Closes #4932

Changes

  • drop support for v1 certificate sync
  • remove legacy code for old version of
    • hare active set grading
    • optimistic filtering
    • p2p discovery
    • fallback data file format

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #5021 (7e7429f) into develop (d204c59) will increase coverage by 0.0%.
The diff coverage is 68.7%.

@@           Coverage Diff            @@
##           develop   #5021    +/-   ##
========================================
  Coverage     77.1%   77.2%            
========================================
  Files          254     254            
  Lines        30363   30072   -291     
========================================
- Hits         23437   23228   -209     
+ Misses        5409    5343    -66     
+ Partials      1517    1501    -16     
Files Changed Coverage Δ
common/types/layer.go 81.8% <ø> (-0.8%) ⬇️
config/config.go 100.0% <ø> (ø)
config/presets/testnet.go 95.5% <ø> (-0.1%) ⬇️
fetch/mesh_data.go 63.0% <ø> (-2.1%) ⬇️
fetch/metrics.go 100.0% <ø> (ø)
hare/config/config.go 100.0% <ø> (ø)
hare/hare.go 67.5% <0.0%> (+1.3%) ⬆️
node/node.go 63.2% <ø> (+<0.1%) ⬆️
p2p/host.go 44.4% <ø> (ø)
p2p/upgrade.go 64.9% <ø> (+1.2%) ⬆️
... and 10 more

... and 2 files with indirect coverage changes

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 16, 2023
@bors
Copy link

bors bot commented Sep 16, 2023

try

Build failed:

@countvonzero
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 16, 2023
@bors
Copy link

bors bot commented Sep 16, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@countvonzero
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 17, 2023
## Motivation
Closes #4932

## Changes
- drop support for v1 certificate sync
- remove legacy code for old version of
  - hare active set grading
  - optimistic filtering
  - p2p discovery
  - fallback data file format
@bors
Copy link

bors bot commented Sep 17, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title drop support for old sync and other legacy code [Merged by Bors] - drop support for old sync and other legacy code Sep 17, 2023
@bors bors bot closed this Sep 17, 2023
@bors bors bot deleted the drop-support-for-old-code branch September 17, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove support for v1 of certificate sync
2 participants