Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add workaround for PoET Round 3 #4969

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Add workaround for PoET Round 3 #4969

wants to merge 5 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Sep 6, 2023 •
edited

Motivation

Closes #4967

Changes

  • For PoET round 3 / publish epoch 4 PoET 111 will be added to the local state to fetch proofs from if the node registered to PoET 110 for that round.

Test Plan

  • Added tests to ensure workaround works for the correct epoch / round

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited

Codecov Report

Merging #4969 (abc7001) into develop (c4240d0) will decrease coverage by 0.1%.
The diff coverage is 64.2%.

@@            Coverage Diff            @@
##           develop   #4969     +/-   ##
=========================================
- Coverage     77.2%   77.2%   -0.1%     
=========================================
  Files          254     254             
  Lines        30092   30141     +49     
=========================================
+ Hits         23237   23271     +34     
- Misses        5354    5365     +11     
- Partials      1501    1505      +4
Files Changed Coverage Δ
activation/nipost.go 81.8% <62.9%> (-3.0%) ⬇️
activation/poet.go 75.6% <100.0%> (+0.3%) ⬆️

... and 3 files with indirect coverage changes

poszu
poszu approved these changes Sep 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@fasmat
Copy link
Member Author

fasmat commented Sep 7, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 7, 2023
@fasmat
Add workaround for PoET Round 3 (#4969)
dd33d6e 
## Motivation
Closes #4967

## Changes
- For PoET round 3 / publish epoch 4 PoET 111 will be added to the local state to fetch proofs from if the node registered to PoET 110 for that round.

## Test Plan
- Added tests to ensure workaround works for the correct epoch / round

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 7, 2023

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Sep 7, 2023

bors merge

@bors
Copy link

bors bot commented Sep 7, 2023

Merge conflict.

@fasmat
Copy link
Member Author

fasmat commented Sep 7, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 7, 2023
@fasmat
Add workaround for PoET Round 3 (#4969)
ba026fc 
## Motivation
Closes #4967

## Changes
- For PoET round 3 / publish epoch 4 PoET 111 will be added to the local state to fetch proofs from if the node registered to PoET 110 for that round.

## Test Plan
- Added tests to ensure workaround works for the correct epoch / round

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 7, 2023

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Sep 7, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 7, 2023
@fasmat
Add workaround for PoET Round 3 (#4969)
b694924 
## Motivation
Closes #4967

## Changes
- For PoET round 3 / publish epoch 4 PoET 111 will be added to the local state to fetch proofs from if the node registered to PoET 110 for that round.

## Test Plan
- Added tests to ensure workaround works for the correct epoch / round

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 7, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Add workaround for PoET Round 3 [Merged by Bors] - Add workaround for PoET Round 3 Sep 7, 2023
@bors bors bot closed this Sep 7, 2023
@bors bors bot deleted the 4967-fetch-poet-111-round-3 branch September 7, 2023 16:05
@fasmat fasmat mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poszu poszu poszu approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

Assignees

@fasmat fasmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node configuration: fetch poet proofs from all poets for round 3
2 participants
@fasmat @poszu