[Merged by Bors] - Avoid races in postVerifier #4965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4965 +/- ##
=========================================
- Coverage 77.2% 77.2% -0.1%
=========================================
Files 254 254
Lines 30081 30092 +11
=========================================
+ Hits 23232 23235 +3
- Misses 5349 5357 +8
Partials 1500 1500
|
fasmat
force-pushed
the
4910-avoid-races-in-postverifier
branch
2 times, most recently
from
4baf2d2
to
096916b
Compare
poszu
reviewed
Sep 7, 2023
fasmat
force-pushed
the
4910-avoid-races-in-postverifier
branch
from
8ceaa93
to
5a22887
Compare
poszu
approved these changes
Sep 7, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
## Motivation Closes #4910, merge after spacemeshos/post#232. ## Changes - Removed `Start` method, a verifier returned from `NewOffloadingPostVerifier` is ready to be used - `Close` cancels ongoing verifications and avoids new ones being started - Updated `node.go` to use the new API ## Test Plan - existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
fasmat
force-pushed
the
4910-avoid-races-in-postverifier
branch
from
5a22887
to
cc8c7fc
Compare
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
## Motivation Closes #4910, merge after spacemeshos/post#232. ## Changes - Removed `Start` method, a verifier returned from `NewOffloadingPostVerifier` is ready to be used - `Close` cancels ongoing verifications and avoids new ones being started - Updated `node.go` to use the new API ## Test Plan - existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4910, merge after spacemeshos/post#232.
Changes
Startmethod, a verifier returned fromNewOffloadingPostVerifieris ready to be usedClosecancels ongoing verifications and avoids new ones being startednode.goto use the new APITest Plan
TODO