-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - hare3: switch to sync validation for gossip messages #4937
[Merged by Bors] - hare3: switch to sync validation for gossip messages #4937
Conversation
bors try |
tryBuild failed: |
bors try |
Codecov Report
@@ Coverage Diff @@
## develop #4937 +/- ##
=========================================
- Coverage 77.1% 77.1% -0.1%
=========================================
Files 263 263
Lines 30532 30542 +10
=========================================
- Hits 23558 23552 -6
- Misses 5486 5501 +15
- Partials 1488 1489 +1
|
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors merge |
currently every validation request spawns new goroutine, the main reason for that was to enable fetching over network without blocking other threads. however hare3 will be spawning many goroutines and it will be much more efficient to execute protocol inline. the same is true for beacon.
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
currently every validation request spawns new goroutine, the main reason for that was
to enable fetching over network without blocking other threads.
however hare3 will be spawning many goroutines and it will be much more efficient to execute protocol inline.
the same is true for beacon.