[Merged by Bors] - sync: require stated synced for node to be synced #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvonzero
changed the title
|
bors try |
Codecov Report
@@ Coverage Diff @@
## develop #4934 +/- ##
=======================================
Coverage 77.0% 77.1%
=======================================
Files 263 263
Lines 30532 30532
=======================================
+ Hits 23537 23543 +6
+ Misses 5503 5497 -6
Partials 1492 1492
|
tryBuild failed: |
countvonzero
force-pushed
the
require-stated-synced
branch
from
f197226
to
55392a0
Compare
dshulyak
approved these changes
Aug 31, 2023
| @@ -35,7 +35,8 @@ func minLayer(a, b types.LayerID) types.LayerID { | |||
|
|
|||
| func (s *Syncer) stateSynced() bool { | |||
| current := s.ticker.CurrentLayer() | |||
| return current.Uint32() <= 1 || !s.mesh.ProcessedLayer().Before(current.Sub(1)) | |||
| return current <= types.GetEffectiveGenesis() || | |||
| (s.mesh.ProcessedLayer() >= current-1 && !s.stateErr.Load()) | |||
There was a problem hiding this comment.
is there a reason why checkMeshAgreement is based on this function instead of synced state?
countvonzero
force-pushed
the
require-stated-synced
branch
from
55392a0
to
8156e5b
Compare
|
bors try |
tryBuild failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
## Motivation Closes #4931 ## Changes - make sure state is synced before declaring node is synced - reduce gossip sync from 10 min to 2 min - do not print confusing log "failed to build proposal" when node is not synced ## Test - manually synced with mainnet ## TODO - [ ] Update [changelog](../CHANGELOG.md)
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
## Motivation Closes #4931 ## Changes - make sure state is synced before declaring node is synced - reduce gossip sync from 10 min to 2 min - do not print confusing log "failed to build proposal" when node is not synced ## Test - manually synced with mainnet
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
## Motivation Closes #4931 ## Changes - make sure state is synced before declaring node is synced - reduce gossip sync from 10 min to 2 min - do not print confusing log "failed to build proposal" when node is not synced ## Test - manually synced with mainnet
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4931
Changes
Test