[Merged by Bors] - Update to go 1.21 #4865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
update-go-1.21
branch
3 times, most recently
from
3abda5e
to
bb00534
Compare
poszu
requested changes
Aug 29, 2023
fasmat
commented
Aug 29, 2023
poszu
reviewed
Aug 29, 2023
fasmat
commented
Aug 29, 2023
Codecov Report
@@ Coverage Diff @@
## develop #4865 +/- ##
=======================================
Coverage 77.1% 77.1%
=======================================
Files 255 254 -1
Lines 30279 30253 -26
=======================================
- Hits 23355 23343 -12
+ Misses 5411 5395 -16
- Partials 1513 1515 +2
... and 4 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
fasmat
force-pushed
the
update-go-1.21
branch
2 times, most recently
from
d58df2b
to
3600ff6
Compare
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
tryBuild failed: |
fasmat
force-pushed
the
update-go-1.21
branch
2 times, most recently
from
c371fc6
to
ffca6ca
Compare
poszu
reviewed
Sep 7, 2023
fasmat
force-pushed
the
update-go-1.21
branch
2 times, most recently
from
ffc33a9
to
be82556
Compare
fasmat
force-pushed
the
update-go-1.21
branch
from
be82556
to
1faae28
Compare
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
poszu
approved these changes
Sep 8, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
## Motivation This updates our codebase to Go 1.21. ## Changes - Update all uses of go to 1.21: `go.mod`, `Dockerfile`s, documentation - replace custom max & min functions with builtin `max` and `mins`, use `clear` to clear slices & maps - fix `staticcheck` and `lint` complaints ## DevOps Notes - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This updates our codebase to Go 1.21.
Changes
go.mod,Dockerfiles, documentationmaxandmins, useclearto clear slices & mapsstaticcheckandlintcomplaintsDevOps Notes