Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add check for next poet round on mainnet to codebase. #4752

Closed
wants to merge 3 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jul 28, 2023

Motivation

Closes #4745

Changes

  • When fetching a poet proof for the publish epoch 1 the state will be updated to duplicate the request for PoET 110 to PoET 111 such that the node will also try to fetch from there even if it didn't submit a proof to it.
  • NIPoSTBuilder was updated to store clients in a map instead of in a slice for easier access.

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #4752 (466e168) into develop (a005d4c) will decrease coverage by 0.1%.
Report is 5 commits behind head on develop.
The diff coverage is 61.0%.

@@            Coverage Diff            @@
##           develop   #4752     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          255     255             
  Lines        28886   28946     +60     
=========================================
+ Hits         22294   22330     +36     
- Misses        5201    5219     +18     
- Partials      1391    1397      +6     
Files Changed Coverage Δ
node/node.go 65.4% <42.8%> (-0.1%) ⬇️
activation/nipost.go 81.1% <61.7%> (-4.3%) ⬇️
activation/poet.go 75.1% <100.0%> (+0.3%) ⬆️

... and 4 files with indirect coverage changes

@fasmat
Copy link
Member Author

fasmat commented Jul 28, 2023

bors try

bors bot added a commit that referenced this pull request Jul 28, 2023
@bors
Copy link

bors bot commented Jul 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

activation/nipost.go Show resolved Hide resolved
node/node.go Show resolved Hide resolved
activation/nipost.go Show resolved Hide resolved
activation/nipost.go Show resolved Hide resolved
activation/nipost.go Show resolved Hide resolved
activation/nipost.go Show resolved Hide resolved
Copy link
Contributor

@countvonzero countvonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will leave it to @poszu to do the final approval. thanks

@fasmat
Copy link
Member Author

fasmat commented Jul 31, 2023

bors merge

@fasmat
Copy link
Member Author

fasmat commented Aug 1, 2023

bors cancel

@fasmat
Copy link
Member Author

fasmat commented Aug 1, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 1, 2023
## Motivation
Closes #4745 

## Changes
- When fetching a poet proof for the publish epoch 1 the state will be updated to duplicate the request for PoET 110 to PoET 111 such that the node will also try to fetch from there even if it didn't submit a proof to it.
- `NIPoSTBuilder` was updated to store clients in a map instead of in a slice for easier access.

## Test Plan
n/a

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Aug 1, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 1, 2023
## Motivation
Closes #4745 

## Changes
- When fetching a poet proof for the publish epoch 1 the state will be updated to duplicate the request for PoET 110 to PoET 111 such that the node will also try to fetch from there even if it didn't submit a proof to it.
- `NIPoSTBuilder` was updated to store clients in a map instead of in a slice for easier access.

## Test Plan
n/a

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Aug 1, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Add check for next poet round on mainnet to codebase. [Merged by Bors] - Add check for next poet round on mainnet to codebase. Aug 1, 2023
@bors bors bot closed this Aug 1, 2023
@bors bors bot deleted the 4745-fetch-from-all-poets-round-0 branch August 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node configuration: fetch poet proofs from all poets in epoch 1
3 participants