Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - validate genesis before using #4719

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - validate genesis before using #4719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e85b00
validate genesis before using
zhiqiangxu Jul 18, 2023
4c36f41
call Initialize before LoadOrCreateEdSigner
zhiqiangxu Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@
}
defer app.Unlock()

if err := app.Initialize(); err != nil {
return err
}

Check warning on line 150 in node/node.go

View check run for this annotation

Codecov / codecov/patch

node/node.go#L148-L150 

Added lines #L148 - L150 were not covered by tests

/* Create or load miner identity */
if app.edSgn, err = app.LoadOrCreateEdSigner(); err != nil {
return fmt.Errorf("could not retrieve identity: %w", err)
Expand All @@ -155,10 +159,6 @@
return err
}

if err := app.Initialize(); err != nil {
return err
}

// This blocks until the context is finished or until an error is produced
err = app.Start(ctx)

Expand Down