Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - hare3: switch to sync validation for gossip messages #4937

Closed

Conversation

dshulyak
Copy link
Contributor

currently every validation request spawns new goroutine, the main reason for that was
to enable fetching over network without blocking other threads.

however hare3 will be spawning many goroutines and it will be much more efficient to execute protocol inline.
the same is true for beacon.

@dshulyak
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 31, 2023
@bors
Copy link

bors bot commented Aug 31, 2023

try

Build failed:

@dshulyak
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4937 (71a8e79) into develop (5d25947) will decrease coverage by 0.1%.
The diff coverage is 55.0%.

❗ Current head 71a8e79 differs from pull request most recent head 3d62477. Consider uploading reports for the commit 3d62477 to get more accurate results

@@            Coverage Diff            @@
##           develop   #4937     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          263     263             
  Lines        30532   30542     +10     
=========================================
- Hits         23558   23552      -6     
- Misses        5486    5501     +15     
- Partials      1488    1489      +1     
Files Changed Coverage Δ
p2p/pubsub/pubsub.go 84.3% <ø> (ø)
p2p/pubsub/mocks/publisher.go 69.6% <50.0%> (-4.3%) ⬇️
hare3/hare.go 84.5% <100.0%> (ø)
p2p/pubsub/wrapper.go 65.9% <100.0%> (ø)

... and 12 files with indirect coverage changes

@bors
Copy link

bors bot commented Aug 31, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dshulyak dshulyak marked this pull request as ready for review August 31, 2023 15:51
@dshulyak
Copy link
Contributor Author

dshulyak commented Sep 1, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 1, 2023
currently every validation request spawns new goroutine, the main reason for that was
to enable fetching over network without blocking other threads.

however hare3 will be spawning many goroutines and it will be much more efficient to execute protocol inline.
the same is true for beacon.
@bors
Copy link

bors bot commented Sep 1, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title hare3: switch to sync validation for gossip messages [Merged by Bors] - hare3: switch to sync validation for gossip messages Sep 1, 2023
@bors bors bot closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants