New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update to go 1.20 #4864
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4864 +/- ##
=========================================
+ Coverage 76.8% 77.0% +0.1%
=========================================
Files 261 260 -1
Lines 29720 29626 -94
=========================================
- Hits 22852 22831 -21
+ Misses 5416 5344 -72
+ Partials 1452 1451 -1
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
I would like to also upgrade to 1.21 after this is merged, but will do it in 2 steps to keep the changes easier to review and test. |
bors merge |
## Motivation Go 1.19 is now EOL and won't be updated any more. This PR updates our codebase to 1.20. ## Changes - update all uses of go to 1.20: `go.mod`, `Dockerfile`s, documentation - instead of top-level deprecated `math/rand` functions use `crypto/rand` or an instance of `*rand.Rand` instead - use `errors.Join` instead of `github.com/hashicorp/go-multierror` - fix `staticcheck` and `lint` complaints ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Motivation
Go 1.19 is now EOL and won't be updated any more. This PR updates our codebase to 1.20.
Changes
go.mod
,Dockerfile
s, documentationmath/rand
functions usecrypto/rand
or an instance of*rand.Rand
insteaderrors.Join
instead ofgithub.com/hashicorp/go-multierror
staticcheck
andlint
complaintsTest Plan
TODO
DevOps Notes