New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add check for next poet round on mainnet to codebase. #4752
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4752 +/- ##
=========================================
- Coverage 77.1% 77.1% -0.1%
=========================================
Files 255 255
Lines 28886 28946 +60
=========================================
+ Hits 22294 22330 +36
- Misses 5201 5219 +18
- Partials 1391 1397 +6
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will leave it to @poszu to do the final approval. thanks
bors merge |
bors cancel |
bors merge |
## Motivation Closes #4745 ## Changes - When fetching a poet proof for the publish epoch 1 the state will be updated to duplicate the request for PoET 110 to PoET 111 such that the node will also try to fetch from there even if it didn't submit a proof to it. - `NIPoSTBuilder` was updated to store clients in a map instead of in a slice for easier access. ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Build failed (retrying...): |
## Motivation Closes #4745 ## Changes - When fetching a poet proof for the publish epoch 1 the state will be updated to duplicate the request for PoET 110 to PoET 111 such that the node will also try to fetch from there even if it didn't submit a proof to it. - `NIPoSTBuilder` was updated to store clients in a map instead of in a slice for easier access. ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Motivation
Closes #4745
Changes
NIPoSTBuilder
was updated to store clients in a map instead of in a slice for easier access.Test Plan
n/a
TODO
DevOps Notes