[Merged by Bors] - validate genesis before using #4719
Conversation
zhiqiangxu
requested review from
countvonzero,
dshulyak,
fasmat and
poszu
as code owners
node/node.go
Outdated
| if err := app.Config.Genesis.Validate(); err != nil { | ||
| return nil, fmt.Errorf("invalid genesis: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
i think it is better to call Initialize before LoadOrCreateSigned in the GetCommand
There was a problem hiding this comment.
Updated accordingly.
Codecov Report
@@ Coverage Diff @@
## develop #4719 +/- ##
=========================================
- Coverage 77.3% 77.3% -0.1%
=========================================
Files 255 255
Lines 28683 28724 +41
=========================================
+ Hits 22191 22213 +22
- Misses 5115 5128 +13
- Partials 1377 1383 +6
|
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors merge |
|
👎 Rejected by too few approved reviews |
Currently if run `fastnet` without specifying a `genesis-time`, will panic: ``` 2023-07-18T10:02:33.246+0200 INFO 00000.defaultLogger Looking for identity file at `/home/dd/post/data/key.bin` panic: code should have run Validate before this method ```
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Currently if run
fastnetwithout specifying agenesis-time, will panic: