emit UnreachableBranch to the "void" condition #1356
Merged
+138
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
reviewed
Nov 26, 2024
test/type_construction_test.rb
Outdated
| @@ -2983,6 +2983,75 @@ def test_if_annotation_success | |||
| end | |||
| end | |||
|
|
|||
| def test_unreachable_if_void | |||
There was a problem hiding this comment.
Please move these tests to type_check_test.rb if you can.
soutaro
reviewed
Nov 26, 2024
| @@ -409,6 +409,8 @@ def partition_union(type) | |||
| ] | |||
| when AST::Types::Any, AST::Types::Boolean, AST::Types::Top, AST::Types::Logic::Base | |||
| [type, type] | |||
| when AST::Types::Bot, AST::Types::Void | |||
It would be better to emit UnreachableBranch diagnostics to use "void" variables for if-conditions.
tk0miya
force-pushed
the
emit_UnreachableBranch_to_void
branch
from
51b631b to
1f0c1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better to emit UnreachableBranch diagnostics to use "void" variables for if-conditions.