-
Notifications
You must be signed in to change notification settings - Fork 31
Update sbt-sourcegraph and re-enable SBT build tool tests #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@keynmol what happens if you remove the |
That seems to have helped - I made buildTools the only module running in parallel |
private val path = BuildInfo | ||
.temporaryDirectory | ||
.toPath | ||
.resolve(self.getClass().getSimpleName()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this so that individual suites don't clobber each other (otherwise you get issues with parallel folder deletion and all that).
Hacky but works for now.
GHA doesn't have the oomph to give us any benefit there
Ok, I made the tests sequential again on CI only - GHA workers have such tiny vCPUs and barely two of them, that it's not worth the increased GC overhead |
@@ -509,7 +509,10 @@ lazy val buildTools = project | |||
Map( | |||
"SCIP_JAVA_CLI" -> ((cli / pack).value / "bin" / "scip-java").toString | |||
), | |||
Test / fork := true | |||
Test / fork := true, | |||
// Our CI set up is a couple of measly vCPUs so parallelising tests there makes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably get access to more powerful buildkite machines if we want to. I never looked into it.
Now that we can run auto-indexing for SBT and support Scala 3, it's time to re-enable the tests
Test plan