bzl: add http_archive to bazel-example #599
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
I confirmed that with this change I was able to index a sample Bazel repo (version had to be 5.2.x though)
This also fills the gap in the docs which point to this file which actually didn't contain the required information.
Thank you so much @jhchabran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http_archiverule was missing which can lead to confusing errors when the users tries to write the rule themselves and forget aboutstrip_prefix, as the.bazelignorefrom this repo will suddenly stop matching theexamplesfolder, leading to build errors about the example itself.Test plan
Tested with the example repo from bazel/java docs.