Set higher RAM percentage in Docker container #585
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On larger Scala/Java projects (I'm using https://github.com/lichess-org/lila it's a very good stress test), SBT's default heap is way too small (1GB), especially if we don't set any concurrency as part of the sbt-sourcegraph plugin (IMO we should)
To give the containers more oomph, we set the special JAVA_TOOL_OPTIONS variable: https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/envvars002.html
Set max RAM percentage to be higher
Use Container support flag: https://www.eclipse.org/openj9/docs/xxusecontainersupport/
This will adjust the max available RAM accordingly
Test plan
Manual testing on large projects