Check annotation path #584
Merged
+151
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
May 11, 2023
Comment on lines
+62
to
+76
| val hasAnnotationPath = { | ||
| val apConfig = project | ||
| .getConfigurations() | ||
| .getByName("annotationProcessor") | ||
| if (apConfig.isCanBeResolved()) { | ||
| apConfig.getDependencies().size() > 0 | ||
| } else | ||
| false | ||
| } | ||
|
|
||
| val compilerPluginAdded = | ||
| try { | ||
| project.getDependencies().add("compileOnly", javacDep) | ||
| if (hasAnnotationPath) | ||
| project.getDependencies().add("annotationProcessor", javacDep) |
keynmol
commented
May 11, 2023
Comment on lines
+21
to
+51
| checkGradleBuild( | ||
| "annotation-path", | ||
| """|/build.gradle | ||
| |plugins { | ||
| | id 'java' | ||
| |} | ||
| |repositories { | ||
| | // Use Maven Central for resolving dependencies. | ||
| | mavenCentral() | ||
| |} | ||
| |dependencies { | ||
| | compileOnly 'org.immutables:value:2.9.2' | ||
| | annotationProcessor 'org.immutables:value:2.9.2' | ||
| |} | ||
| |/src/main/java/WorkflowOptions.java | ||
| |package test; | ||
| |import org.immutables.value.Value; | ||
| |import java.util.Optional; | ||
| |@Value.Immutable | ||
| |public abstract class WorkflowOptions { | ||
| | public abstract Optional<String> getWorkflowIdReusePolicy(); | ||
| |} | ||
| """.stripMargin, | ||
| /* | ||
| An immutable version will be generated along with the original class: | ||
| - build/generated/sources/annotationProcessor/java/main/test/ImmutableWorkflowOptions.java.semanticdb | ||
| - /META-INF/semanticdb/src/main/java/WorkflowOptions.java.semanticdb | ||
| */ | ||
| expectedSemanticdbFiles = 2, | ||
| gradleVersions = List(Gradle8, Gradle7, Gradle67) | ||
| ) |
There was a problem hiding this comment.
Test for the meat of the PR
olafurpg
approved these changes
May 12, 2023
| set -eu | ||
| for REPO in circe/circe indeedeng/proctor | ||
| do | ||
| check_repo() { |
There was a problem hiding this comment.
Might be nice to move this script into a separate file in the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If annotation processors are used, then compileOnly classpath is ignored entirely.
We attempt to add the plugin to that, but if it fails - it gives us a clear signal to go back to agents instead.
Test plan