Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all directories as "safe" for Git in the indexer docker container #580

Merged
merged 9 commits into from
May 9, 2023

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented May 9, 2023

Currently, autoindexing some projects (like typelevel/cats-effect) throws an error:

image

We mark all directories as safe as part of the container build to circumvent that.

Test plan

  • Manual testing
  • Add a Docker integration test to CI with repos that use sbt-dynver

@keynmol keynmol force-pushed the git-make-all-safe-directories branch from cf6cd02 to dad1258 Compare May 9, 2023 14:16
@keynmol keynmol marked this pull request as ready for review May 9, 2023 14:30
@keynmol keynmol requested a review from olafurpg May 9, 2023 14:30
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a gnarly issue. LGTM

@keynmol keynmol merged commit 9ec7a06 into main May 9, 2023
@keynmol keynmol deleted the git-make-all-safe-directories branch May 9, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants