Emit inverse relationships #566
Merged
+276
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #413. Previously, "find references" and "find implementations" didn't work as expected with Sourcegraph 5.0 due to https://github.com/sourcegraph/sourcegraph/issues/50927. This PR is a workaround until that issue gets fixed so that users can index with scip-java and get the best possible navigation experience.
keynmol
reviewed
Apr 28, 2023
Comment on lines
+37
to
+44
| // relationship is_reference is_implementation ujson/IndexedValue.Arr#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.False#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.Null#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.Num#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.NumRaw#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.Obj#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.Str#index. | ||
| // relationship is_reference is_implementation ujson/IndexedValue.True#index. |
There was a problem hiding this comment.
Implementation-wise I think the PR is fine, I'm just concerned about plugging the holes in the backend with something that increases the size of the SCIP index.
This example is probably on the extreme end of the spectrum
There was a problem hiding this comment.
I'm not so concerned about index size getting bloated from this change. These relationships represent a tiny part of the payload since most of the overhead comes from basic occurrences (just a single import statement can emit 5-6 occurrences). Symbols also have a lot of redundancy that gets compressed away.
keynmol
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413. Previously, "find references" and "find implementations" didn't work as expected with Sourcegraph 5.0 due to https://github.com/sourcegraph/sourcegraph/issues/50927.
This PR is a workaround until that issue gets fixed so that users can index with scip-java and get the best possible navigation experience.
Test plan
See updated snapshots.