Close SCIP/LSIF feature gap

[olafurpg]

Previously, scip-java had custom support for Scala that was only
supported by the LSIF writer. This meant that Scala users were
recommended to use LSIF instead of SCIP.

Now that Sourcegraph supports native SCIP uploads (and stores SCIP in
the database) it's time to close this feature gap so that Scala
users can use SCIP instead of LSIF.

Test plan

See updated snapshot tests.

[keynmol]

Should we

1. Sort relationships by symbol?
2. Sort documentation strings?

I can't reproduce the failures locally, but on CI it seems to be order related:

+//                      relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#clearView().
 //                      relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/EpoxyTouchHelperCallback#clearView(+1).
 //                      relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/EpoxyTouchHelperCallback#clearView().
-//                      relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#clearView().
 //                      ^ reference semanticdb maven . . com/airbnb/epoxy/EpoxyModelTouchCallback#[T]

Here's suggested patch (but this will require regenerating snapshots):

Suggested change

	0.until(info.getDocumentationCount)
	.foreach { n =>
	val documentation = info.getDocumentation(n)
	out
	.append(prefix)
	.append("documentation ")
	.append(documentation.replace("\n", "\\n").replace("\t", "\\t"))
	.append("\n")
	}
	0.until(info.getRelationshipsCount)
	.foreach { n =>
	val relationship = info.getRelationships(n)
	out.append(prefix).append("relationship")
	val docs =
	0.until(info.getDocumentationCount).map(info.getDocumentation).sorted
	docs.foreach { documentation =>
	out
	.append(prefix)
	.append("documentation ")
	.append(documentation.replace("\n", "\\n").replace("\t", "\\t"))
	.append("\n")
	}
	val relationships = 0
	.until(info.getRelationshipsCount())
	.map(info.getRelationships)
	.sortBy(_.getSymbol())
	relationships.foreach { relationship =>
	out.append(prefix).append("relationship")

[olafurpg]

The failure was probably because I hadn't rebased on top of the scip-snapshots branch, which was failing with the same error. I've rebased now and will see if CI becomes green.

[olafurpg]

CI is green :letsgooo: