Move to SCIP snapshots #556
Merged
+27,679
−22,784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `LibrarySnapshotGenerator` was not working correctly making it impossible to update the snapshots with `snapshots/run`. This commit fixes the issue and updates the snapshots to reflect several versions of scip-java updates.
olafurpg
commented
Apr 19, 2023
| // NOTE: At the moment, due to limitations of the SCIP to LSIF conversion, | ||
| // only global symbols in an index are allowed to use is_definition. | ||
| // The relationship may not get recorded if either symbol is local. | ||
| bool is_definition = 5; |
There was a problem hiding this comment.
This isn't strictly needed for this PR but it will be needed in the next PR and having it here allows ScipPrinters to support it off the bat.
olafurpg
force-pushed
the
olafurpg/scip-snapshots
branch
from
f907b23 to
614ee50
Compare
Previously, this repo used SemanticDB and LSIF snapshot tests. This commit replaces both of those with SCIP snapshot tests. The LSIF snapshot tests are no longer needed since the SCIP snapshot format captures the relevant details we tried to assert against with the LSIF snapshot tests. The SemanticDB tests are not needed since they look almost identical to SCIP snapshot excluding the extra details SCIP encodes (cross-repo package information and symbol relationships).
olafurpg
force-pushed
the
olafurpg/scip-snapshots
branch
from
614ee50 to
927cd0a
Compare
keynmol
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this repo used SemanticDB and LSIF snapshot tests.
This commit replaces both of those with SCIP snapshot tests.
The LSIF snapshot tests are no longer needed since the SCIP snapshot
format captures the relevant details we tried to assert against with the
LSIF snapshot tests. The SemanticDB tests are not needed since they look
almost identical to SCIP snapshot excluding the extra details SCIP
encodes (cross-repo package information and symbol relationships).
Test plan
See updated SCIP snapshot tests.