Fix snapshot tests #555
Merged
Fix snapshot tests #555
+1,108
−1,307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
commented
Apr 19, 2023
| @@ -70,12 +71,16 @@ final case class IndexDependencyCommand( | |||
| snapshotCommand | |||
| .copy( | |||
| output = snapshotTarget, | |||
| cleanup = cleanup, | |||
| targetroot = List(indexTarget), | |||
There was a problem hiding this comment.
This line fixed the issue. The other diffs are not necessary but make the --cleanup flag work correctly, which is helpful for debugging in cases like this.
Previously, the `LibrarySnapshotGenerator` was not working correctly making it impossible to update the snapshots with `snapshots/run`. This commit fixes the issue and updates the snapshots to reflect several versions of scip-java updates.
olafurpg
force-pushed
the
olafurpg/fix-snapshots
branch
from
9527aff to
052f671
Compare
keynmol
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
LibrarySnapshotGeneratorwas not working correctly making it impossible to update the snapshots withsnapshots/run. This commit fixes the issue and updates the snapshots to reflect several versions of scip-java updates.Test plan
See updated snapshot tests.